Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1687
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1687#discussion_r53777248
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -17,41 +17,50 @@
*/
package
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187705826
Thanks for your work @aljoscha. Changes look good to me. I'll address
Robert's concern and then merge the PR.
---
If your project is set up for it, you can reply
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1687#discussion_r53780485
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -17,41 +17,50 @@
*/
package
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187692550
+1 to merge this change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187328780
Ahh, stupid beginners mistake. Fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187323846
Fails on checkstyle, otherwise looks good...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187202268
Should be the correct code now. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1687#discussion_r53629014
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -26,32 +25,46 @@
import java.io.File;
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1687#discussion_r53628814
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -26,32 +25,46 @@
import java.io.File;
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1687
[FLINK-3418] Don't run RocksDB copy utils in external process
This was causing to many problems with security tokens and yarn. Now,
let the RocksDB backup run in a thread but
don't
11 matches
Mail list logo
