[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1665 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-23 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-187608866 Thanks for your contribution @stefanobaghino. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-187250281 The test failure looks unrelated to this fix. +1 to merge this --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-22 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-187248829 Running the test locally with the same `PROFILE` as the failing tests do not yield the same results (i.e. all tests pass). Is there a way to determine if this was

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-18 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-185756748 I'm going into the direction proposed by @StephanEwen, the change looks trivial. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-185732111 Should be okay for the tests. Just make sure you don't try to parse the returned stderr stream, but simply take non-empty stream as an exception with a copy

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-185636882 Anyone against merging this as a (maybe temporary) solution? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-18 Thread stefanobaghino
GitHub user stefanobaghino opened a pull request: https://github.com/apache/flink/pull/1665 [FLINK-3438] ExternalProcessRunner fails to detect ClassNotFound exception because of locale settings This should be regarded as a temporary solution to this issue in particular. See the dis