Github user vasia closed the pull request at:
https://github.com/apache/flink/pull/1696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188878585
Thanks! I'll merge both once Travis passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188846370
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188701788
Thanks @twalthr! You PR solves the problem indeed :)
If no objections, I will merge both #1709 and this one rebased on your
changes.
---
If your project is set up
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188679737
I have opened a PR (#1709) that adds some documentation and does some type
checking for aggregates. The problem is that aggregates do not support other
types than
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188654410
Forwarding the expected type is not an option, because you don't know what
the previous operator produces. If the previous operator produces `Tuple5` and
you force it
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188268518
I've updated the PR.
Changing the test to `TableProgramsTestBase ` actually made the
`TestCalcWithAggregation` test fail for `config=EFFICIENT` on a
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53941468
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/CalcITCase.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53925000
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/CalcITCase.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188181343
Thanks @fhueske and @twalthr for the comments! Apart from a small doubt
with the test, I've addressed the rest.
---
If your project is set up for it, you can reply to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53918915
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/CalcITCase.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-188138683
@vasia PR looks good. Cool, that you found a way to trigger a calc without
custom rules.
---
If your project is set up for it, you can reply to this email and have
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53907367
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetCalcRule.scala
---
@@ -37,13 +45,90 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53906764
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/CalcITCase.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1696#discussion_r53906601
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/CalcITCase.scala
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1696#issuecomment-187937363
I think we can also remove `FlinkProject` and `FlinkFilter` since there are
no rules left that translate to these RelNodes.
Otherwise looks good to me.
---
If your
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1696
[FLINK-3463] implement calc translation
This PR implements the `DataSetCalcRule`, so that filters, projections, and
their combinations are now translated to `FlinkCalc`s. `FlinkFilterRule`,
17 matches
Mail list logo
