Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-216896787
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-216378193
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-204682353
OK, no problem, I've updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-195743886
> What kind of exception do you get?
This is the code near TypeExtractor.java:1379, from where the exception is
thrown:
```
// check for
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-195490545
What kind of exception do you get?
Also, subclasses of tuples that do not have additional fields can need not
be Pojos (even though Tuples by themselves
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-190143075
> I am not quite sure even, if Tuple subclasses have to be POJOs.
I wrote that based on the comment at TypeExtractor.java:1687. (I also tried
adding a check
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-189400067
Good idea to update these comments.
I am not quite sure even, if Tuple subclasses have to be POJOs.
---
If your project is set up for it, you can reply to
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1724#issuecomment-189326695
I have also added that a subclass of TupleN can only be a POJO. (see
TypeExtractor.java:1686)
---
If your project is set up for it, you can reply to this email and have
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/1724
[FLINK-3519] [core] Add warning about subclasses to Tuple javadocs.
I went with option (2), that is, adding a warning to the javadocs.
The generated classes were out of sync with the
10 matches
Mail list logo
