Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-203004909
I'm going to merge this to `master` and `release-1.0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-202794232
OK, depending on whether it is feasible to test this separately, I would go
ahead and merge it as is or add a test and merge then. :+1:
---
If your project is set up for
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-200863307
Yes, what @rmetzger said is correct. Without the fix and the increase of
parallelism it will be a flaky test that still succeeds sometimes.
---
If your project is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-200796710
I think the test fails only sporadically, depending on the speed at which
tasks are deleting the files.
If you are lucky, everything is correct.
---
If your
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1830#issuecomment-200795802
Good catch! The changes look good to me.
I tried running the adjusted `RollingSinkFaultToleranceITCase` and
`RollingSinkFaultTolerance2ITCase` w/o the fix in
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1830
[FLINK-3651] Fix faulty RollingSink Restore
On restore the sink for subtask index i has to cleanup leftover files
for subtask i. The pattern used for checking this was not properly
