[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-04-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-214246110 I'll merge it into 1.0.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-04-01 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-204405759 Thanks! Hope it will make it to 1.0.1. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-04-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-04-01 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-204309933 Yes, I'm going to merge it later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-04-01 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-204301276 I think this is ready. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1837#discussion_r57986135 --- Diff: docs/setup/config.md --- @@ -275,6 +275,10 @@ For example when running Flink on YARN on an environment with a restrictive fire -

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1837#discussion_r57955999 --- Diff: docs/setup/config.md --- @@ -275,6 +275,10 @@ For example when running Flink on YARN on an environment with a restrictive fire -

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1837#discussion_r57913426 --- Diff: docs/setup/config.md --- @@ -275,6 +275,10 @@ For example when running Flink on YARN on an environment with a restrictive fire -

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1837#discussion_r57900813 --- Diff: docs/setup/config.md --- @@ -275,6 +275,10 @@ For example when running Flink on YARN on an environment with a restrictive fire -

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-203462424 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-30 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1837#issuecomment-203323834 I tested this PR in local cluster. Looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3678] Make Flink logs directory configu...

2016-03-29 Thread stefanobaghino
GitHub user stefanobaghino opened a pull request: https://github.com/apache/flink/pull/1837 [FLINK-3678] Make Flink logs directory configurable * Edit config.sh * Document the newly defined log directory configuration key You can merge this pull request into a Git repository by