[GitHub] flink pull request: [FLINK-3758] Add possibility to register accumulators in...

2016-06-01 Thread StephanEwen
Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1979
  
Sorry for chiming in late.

I was wondering whether we actually need accumulators here, or what we 
should add is access to the metrics. Because the use case seems to be 
"monitoring", not "side aggregates".

Admittedly, the accumulators were the means of choice for metrics up to 
now, but for the future (now that we are adding proper metrics), we may want to 
fix this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: [FLINK-3758] Add possibility to register accumulators in...

2016-05-31 Thread rmetzger
Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1979
  
How about tagging the new method with `@PublicEvolving`. Since its a new 
API anyways, its good not to make it part of the stable interfaces.

With Flink 2.0, we can remove the `Evolving` part ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---