[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/306#issuecomment-69967270
  
Ah ok, thanks for the info Stephen, good to know it was intentional.
Do you want to keep this pattern?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request: FLINK-1402 - Remove Serializable extends from ...

2015-01-14 Thread hsaputra
Github user hsaputra commented on the pull request:

https://github.com/apache/flink/pull/306#issuecomment-69992202
  
I don't remember if there any best practice about this, so If we think it 
is useful we could keep this style and maybe document it?
But I don't think it is good practice for other interfaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---