[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-04-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-04-06 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-90250843 Thanks, now the Twitter one runs fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-26 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-86565008 I tried to fix issue FLINK-1662, that is related to IterateExample. Gyula, what do you think? To see the actual bug, run IterateExample with parallelism 1 without the

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-26 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-86569586 @szape: I've started merging this: The TwitterStreamITCase seems to fail spuriously. Could you look into it? --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-26 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-86582509 It runs just fine on my computer. Did you pull the latest state of the branch? The TwitterStreamData class was updated not so long ago. Also, the IterateExample isn't

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/519 FLINK-1560 - Add ITCases for streaming examples ITCases for streaming examples have been added, except for IterateExample and StockPrices. I replaced the IterateExample with one that generates

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/519#discussion_r26938775 --- Diff:

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/519#discussion_r26939215 --- Diff: flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java --- @@

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-85019063 Please update this for parallelism of 4. Besides that and the inline comments looks good. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/519#discussion_r26939465 --- Diff: flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/twitter/TwitterStream.java --- @@ -176,11

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-85075533 Thank you guys! I corrected the errors. Updating the ITCases for parallelism 4 will be easier than I thought, but windowing makes it hard to test WindowJoin and