[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-17 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1137#issuecomment-141006345 Thanks for the update. Will merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/1137 FLINK-2595 Unclosed JarFile may leak resource in ClassLoaderUtilsTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/flink master

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1137#discussion_r39676482 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java --- @@ -46,13 +46,16 @@ public void testWithURLClassLoader() {

[GitHub] flink pull request: FLINK-2595 Unclosed JarFile may leak resource ...

2015-09-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1137#issuecomment-140868278 Hi @tedyu, Thanks for the pull request! It's good to merge after the the indention is fixed. --- If your project is set up for it, you can reply to this email