[GitHub] flink pull request: FLINK-3808: Refactor the whole file monitoring...
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-219732847 This is now included in https://github.com/apache/flink/pull/1984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: FLINK-3808: Refactor the whole file monitoring...
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/1929 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: FLINK-3808: Refactor the whole file monitoring...
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-216545948 Ah man, you're right, the test needs to be moved to the `flink-fs-tests` package, I think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: FLINK-3808: Refactor the whole file monitoring...
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-216503327 One related test failure; the hadoop dependency could not be found for PROFILE="-Dhadoop.profile=1" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: FLINK-3808: Refactor the whole file monitoring...
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1929#issuecomment-215446453 I'm very happy with this now. ð Looks good to merge. Now for the checkpointable `InputFormat` and actually putting it into the API... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
