Github user mans2singh commented on the pull request:
https://github.com/apache/flink/pull/2031#issuecomment-222030024
Hi @rmetzger
Thanks for your advice/suggestions. I will try to answer your questions
below:
Regarding motivation for the connector - I started
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2031#issuecomment-221886697
Hi @mans2singh,
thanks a lot for this contribution. I wonder what's your motivation to
implement a flink --> rethinkdb connector? I'm asking because the Flink
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64727151
--- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
@@ -0,0 +1,100 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64724883
--- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
@@ -0,0 +1,100 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user mans2singh commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64720893
--- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
@@ -0,0 +1,100 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64709407
--- Diff: flink-streaming-connectors/flink-connector-rethinkdb/pom.xml ---
@@ -0,0 +1,100 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user mans2singh commented on the pull request:
https://github.com/apache/flink/pull/2031#issuecomment-221737718
Hey @zentol - Thanks for your feedback.
- I've renamed the sink as you had recommended.
- Currently the driver from rethinkdb supports java 8 only. There
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/2031#issuecomment-221497411
All travis builds failed.
For Java 8 several RethinkDB tests failed.
For Java 7 we get an Unsupported Major/Minor version error. Does this Sink
(or
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64527910
--- Diff:
flink-streaming-connectors/flink-connector-rethinkdb/src/main/java/org/apache/flink/streaming/connectors/rethinkdb/FlinkRethinkDbSink.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2031#discussion_r64527750
--- Diff:
flink-streaming-connectors/flink-connector-rethinkdb/src/main/java/org/apache/flink/streaming/connectors/rethinkdb/FlinkRethinkDbSink.java
---
@@
GitHub user mans2singh opened a pull request:
https://github.com/apache/flink/pull/2031
FLINK-3967 - Flink Sink for Rethink Db
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
11 matches
Mail list logo
