Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-96828941
This PR was split into PR #632 and PR #633
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r29129684
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r29130488
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28966088
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28961417
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28869610
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28805740
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28765996
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28765691
--- Diff: flink-staging/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -22,14 +22,13 @@
--
configuration
+!--
--- End diff
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28765745
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28766220
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-94735401
Looks good, except two minor things.
Once these are resolved I would merge it and also backport it to the 0.8
branch.
---
If your project is set up for it, you can
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28766303
--- Diff: flink-staging/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -22,14 +22,13 @@
--
configuration
+!--
--- End diff
Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28766073
--- Diff: flink-staging/flink-hbase/src/test/resources/hbase-site.xml ---
@@ -22,14 +22,13 @@
--
configuration
+!--
--- End
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r28768490
--- Diff: flink-staging/flink-hbase/pom.xml ---
@@ -112,6 +112,12 @@ under the License.
/exclusion
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-90481118
Ok, I created this issue (https://issues.apache.org/jira/browse/FLINK-1834)
about the mapred.output.dir
---
If your project is set up for it, you can reply to this
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-90475934
Is the Hadoop configuration specified in the flink-conf.yaml loaded? If we
set `mapred.output.dir` then we should check for an existing config entry
beforehand. Otherwise, we
GitHub user fpompermaier opened a pull request:
https://github.com/apache/flink/pull/571
Fixed Configurable HadoopOutputFormat (FLINK-1828)
See https://issues.apache.org/jira/browse/FLINK-1828
You can merge this pull request into a Git repository by running:
$ git pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r27768581
--- Diff:
flink-staging/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteExample.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/571#discussion_r27768585
--- Diff:
flink-staging/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteExample.java
---
@@ -0,0 +1,197 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-89559472
Looks good to me, except for some comments that should be removed.
Regarding the `mapred.output.dir` parameter I am not sure whether this is
generally expected
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/571#issuecomment-89570344
Removed comments and commented code as suggested by Fabian. Do I have also
to create a JIRA ticket about mapred.output.dir parameter? I think that it can
be
23 matches
Mail list logo
