[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78440416 Is there a JIRA associated with this PR? Once the issues with the documentation are resolved, I'd say its good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26215888
--- Diff: docs/_includes/navbar.html ---
@@ -24,15 +24,15 @@
We might be on an externally hosted documentation site.
Please keep the site.FLINK_WEBSITE_URL below to ensure a link back
to the Flink website.
{% endcomment %}
- a href={{ site.FLINK_WEBSITE_URL }}index.html title=Home
+ a href={{ site.FLINK_WEBSITE_URL }}/index.html title=Home
img class=hidden-xs hidden-sm img-responsive
- src={{ site.baseurl }}img/logo.png alt=Apache Flink Logo
+ src={{ site.baseurl }}/img/logo.png alt=Apache Flink Logo
/a
div class=row visible-xs
div class=col-xs-3
- a href={{ site.baseurl }}index.html title=Home
+ a href={{ site.baseurl }}/index.html title=Home
--- End diff --
Yes, we can set in it the _config.yml. I would not change it now because it
has some other implications. For example, local testing of the website will be
more complicated because all links will point to the online version. We can
open a separate issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78300593 Nice solution. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26219828
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
--- End diff --
Local testing should work out of the box. We could set `{{site.baseurl}}`
to http://ci.apache.org/projects/flink/flink-docs-master/ and then change our
build_docs script to serve the website for local testing with the `--baseurl
http://127.0.01/` parameter. If you want, you can fix this here or we open a
JIRA for that.
http://jekyllrb.com/docs/configuration/#serve-command-options
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78441869 No there is no Jira issue for the machine learning library. The problem with the links should be fixed. On Mar 12, 2015 9:30 AM, Robert Metzger notificati...@github.com wrote: Is there a JIRA associated with this PR? Once the issues with the documentation are resolved, I'd say its good to merge. â Reply to this email directly or view it on GitHub https://github.com/apache/flink/pull/479#issuecomment-78440416. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78541637 @tillrohrmann, could you fire JIRA for this one? Should help when we want to manage releases or merge between branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26227591
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
--- End diff --
Yes, this should fix the problem. I'll add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78298992
I set the ```{{ site.baseurl }}``` to
http://ci.apache.org/projects/flink/flink-docs-master and the local preview is
started with ```--baseurl ```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/479#issuecomment-78257904 Really nice work, Till! Very nicely documented. Just made a few comments concerning the paths for the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/479 Kick off of Flink's machine learning library This PR contains the kick off of Flink's machine learning library. Currently it contains implementations for ALS, multiple linear regression and polynomial base feature mapper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink flink-ml Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 71afb4ba942840a3bc37c9b67749a8ebbd0ae41b Author: Till Rohrmann trohrm...@apache.org Date: 2015-02-27T12:43:46Z [ml] Initial commit to establish module structure. Adds simple Vector and Matrix types. commit 5e0e42c4746dcca4f266e7a946edf8d07173820e Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-02T13:39:18Z [ml] Adds batch gradient descent linear regression with l2 norm [ml] Adds batch gradient descent linear regression with convergence criterion as relative change in sum of squared residuals [ml] Adds comments to MultipleLinearRegression commit 2a04c750d55922b359cec80c0d46a49001f38cca Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-05T13:05:59Z [ml] Adds alternating least squares (ALS) implementation with test case [ml] Adds comments to ALS commit 933e263609558547591779c7543079d62a5f9a83 Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-06T14:27:25Z [ml] Introduces FlinkTools containing persist methods. [ml] Changes comments into proper ScalaDoc in MultipleLinearRegression commit be01b5132589d5a4337887b2e26dbd299959655f Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-09T17:10:52Z [ml] Adds polynomial base feature mapper and test cases [ml] Adds comments to PolynomialBase commit d923033eafc5fffd49a1ea587af453d779ff2b65 Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-10T11:26:37Z [ml] Adds web documentation for multiple linear regression. Changes website links from relative to absolute. commit 2340f7283fbd0c6ffbe18d2d62d76f5abc628e28 Author: Till Rohrmann trohrm...@apache.org Date: 2015-03-10T14:41:40Z [ml] Adds web documentation for alternating least squares. Adds web documentation for polynomial base feature mapper. [ml] Adds comments [ml] Set degree of parallelism of test suites to 2 [ml] Replaces FlatSpec tests with JUnit integration test cases in order to suppress the sysout output. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205510
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
script
src=https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js;/script
-script src={{ site.baseurl }}js/bootstrap.min.js/script
-script src={{ site.baseurl }}js/codetabs.js/script
+script src={{ site.baseurl }}/js/bootstrap.min.js/script
+script src={{ site.baseurl }}/js/codetabs.js/script
+
+{% if page.mathjax %}
+script type=text/x-mathjax-config
+MathJax.Hub.Config({tex2jax: {inlineMath: [['$','$'],
['\\(','\\)']]}});
+/script
+script type=text/javascript
+
src=https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML;
--- End diff --
ASL2.0, so thats good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205970
--- Diff: docs/_includes/navbar.html ---
@@ -24,15 +24,15 @@
We might be on an externally hosted documentation site.
Please keep the site.FLINK_WEBSITE_URL below to ensure a link back
to the Flink website.
{% endcomment %}
- a href={{ site.FLINK_WEBSITE_URL }}index.html title=Home
+ a href={{ site.FLINK_WEBSITE_URL }}/index.html title=Home
img class=hidden-xs hidden-sm img-responsive
- src={{ site.baseurl }}img/logo.png alt=Apache Flink Logo
+ src={{ site.baseurl }}/img/logo.png alt=Apache Flink Logo
/a
div class=row visible-xs
div class=col-xs-3
- a href={{ site.baseurl }}index.html title=Home
+ a href={{ site.baseurl }}/index.html title=Home
--- End diff --
This will point the Home button to http://ci.apache.org instead of the
documentation. {{ site.baseurl }} is actually not set in the config. We could
set it to the current docs or just keep the relative links which worked fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/479#discussion_r26205980 --- Diff: docs/_includes/sidenav.html --- @@ -17,51 +17,51 @@ under the License. -- ul id=flink-doc-sidenav - lidiv class=sidenav-categorya href=faq.htmlFAQ/a/div/li + lidiv class=sidenav-categorya href=/faq.htmlFAQ/a/div/li --- End diff -- Same as above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205978
--- Diff: docs/_includes/navbar.html ---
@@ -49,15 +49,15 @@
ul class=nav navbar-nav
li
- a href=index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
+ a href=/index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
/li
li
- a href=api/java/index.htmlJavadoc/a
+ a href=/api/java/index.htmlJavadoc/a
/li
li
- a
href=api/scala/index.html#org.apache.flink.api.scala.packageScaladoc/a
+ a
href=/api/scala/index.html#org.apache.flink.api.scala.packageScaladoc/a
--- End diff --
Same as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205983
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
--- End diff --
This will break the loading of stylesheets on our website. {{ site.baseurl
}} is actually not set in the config. Thus the path /css will load the css
path of http://ci.apache.org
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205976
--- Diff: docs/_includes/navbar.html ---
@@ -49,15 +49,15 @@
ul class=nav navbar-nav
li
- a href=index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
+ a href=/index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
/li
li
- a href=api/java/index.htmlJavadoc/a
+ a href=/api/java/index.htmlJavadoc/a
--- End diff --
Same as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26205975
--- Diff: docs/_includes/navbar.html ---
@@ -49,15 +49,15 @@
ul class=nav navbar-nav
li
- a href=index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
+ a href=/index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
--- End diff --
Please use relative paths. This will fail with our current docs setup
because the base url is http://ci.apache.org/projects/flink/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26212489
--- Diff: docs/_includes/navbar.html ---
@@ -24,15 +24,15 @@
We might be on an externally hosted documentation site.
Please keep the site.FLINK_WEBSITE_URL below to ensure a link back
to the Flink website.
{% endcomment %}
- a href={{ site.FLINK_WEBSITE_URL }}index.html title=Home
+ a href={{ site.FLINK_WEBSITE_URL }}/index.html title=Home
img class=hidden-xs hidden-sm img-responsive
- src={{ site.baseurl }}img/logo.png alt=Apache Flink Logo
+ src={{ site.baseurl }}/img/logo.png alt=Apache Flink Logo
/a
div class=row visible-xs
div class=col-xs-3
- a href={{ site.baseurl }}index.html title=Home
+ a href={{ site.baseurl }}/index.html title=Home
--- End diff --
Do we have control over ```{{ site.baseurl }}}```? The problem with the
relative links is that you cannot have websites in different directories than
the root directory. IMHO this is not how it should be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26212689
--- Diff: docs/_includes/navbar.html ---
@@ -49,15 +49,15 @@
ul class=nav navbar-nav
li
- a href=index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
+ a href=/index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
--- End diff --
Then we should try to change the way the docs are linked I think. Relative
paths don't allow you to have any kind of directory structure for the html
files. Maintaining a directory with all our html files will quickly become a
big mess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26215901
--- Diff: docs/_includes/navbar.html ---
@@ -49,15 +49,15 @@
ul class=nav navbar-nav
li
- a href=index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
+ a href=/index.html class={% if page.url contains 'index.html'
%}active{% endif %}Documentation/a
--- End diff --
We could set the `base href=http://ci.apache.org/projects/flink/.../;`
in the header. That way, we would be able to use relative links. However,
hard-coding the link to the docs in the template variables, is also not a very
nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26212353
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
script
src=https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js;/script
-script src={{ site.baseurl }}js/bootstrap.min.js/script
-script src={{ site.baseurl }}js/codetabs.js/script
+script src={{ site.baseurl }}/js/bootstrap.min.js/script
+script src={{ site.baseurl }}/js/codetabs.js/script
+
+{% if page.mathjax %}
+script type=text/x-mathjax-config
+MathJax.Hub.Config({tex2jax: {inlineMath: [['$','$'],
['\\(','\\)']]}});
+/script
+script type=text/javascript
+
src=https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML;
--- End diff --
Good point. I did not check it. Thanks for doing so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Kick off of Flink's machine learning library
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26212866
--- Diff: docs/_layouts/default.html ---
@@ -23,16 +23,25 @@
meta http-equiv=X-UA-Compatible content=IE=edge
meta name=viewport content=width=device-width, initial-scale=1
titleApache Flink: {{ page.title }}/title
-link rel=shortcut icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=icon href={{ site.baseurl }}favicon.ico
type=image/x-icon
-link rel=stylesheet href={{ site.baseurl }}css/bootstrap.css
-link rel=stylesheet href={{ site.baseurl
}}css/bootstrap-lumen-custom.css
-link rel=stylesheet href={{ site.baseurl }}css/syntax.css
-link rel=stylesheet href={{ site.baseurl }}css/custom.css
-link href={{ site.baseurl }}css/main/main.css rel=stylesheet
+link rel=shortcut icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=icon href={{ site.baseurl }}/favicon.ico
type=image/x-icon
+link rel=stylesheet href={{ site.baseurl }}/css/bootstrap.css
+link rel=stylesheet href={{ site.baseurl
}}/css/bootstrap-lumen-custom.css
+link rel=stylesheet href={{ site.baseurl }}/css/syntax.css
+link rel=stylesheet href={{ site.baseurl }}/css/custom.css
+link href={{ site.baseurl }}/css/main/main.css rel=stylesheet
--- End diff --
Well it seems to be empty. Why do we have ```{{ site.baseurl }}``` in the
first place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
