[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-86112294 I fixed @rmetzger's remarks. Still waiting for a solution to the naming issue. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26974832 --- Diff: docs/linq.md --- @@ -23,58 +23,91 @@ under the License. * This will be replaced by the TOC {:toc} -**Language-Integrated Queries

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26974798 --- Diff: docs/linq.md --- @@ -23,58 +23,91 @@ under the License. * This will be replaced by the TOC {:toc} -**Language-Integrated Queries

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26975057 --- Diff: docs/linq.md --- @@ -23,58 +23,91 @@ under the License. * This will be replaced by the TOC {:toc} -**Language-Integrated Queries

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26974901 --- Diff: docs/linq.md --- @@ -23,58 +23,91 @@ under the License. * This will be replaced by the TOC {:toc} -**Language-Integrated Queries

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26975267 --- Diff: flink-staging/flink-table/src/main/java/org/apache/flink/api/java/table/package-info.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/503#discussion_r26977728 --- Diff: flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/AggregationsITCase.java --- @@ -0,0 +1,210 @@ +/* + *

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-23 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-85188465 The code looks good. Impressive test coverage, some documentation, amazing feature. Once the political issues (name) are resolved, :+1: to merge. Do you

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-21 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84384122 Gah, I just did that in the discuss thread =P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84382628 Exactly, thanks @hsaputra It would also be good to add some actual arguments to the discussion that go beyond I like xxx more than yyy ;-) --- If your project is

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-21 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84381205 I think @fhueske just suggetsing it would be less work to have the new name settle before PR being submmitted. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-21 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-84488745 Touché --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/503#issuecomment-83969916 Correct, that's why I'm doing a Pull Request. People can chime in here if they want. Or should we continue the discussion on the mailing list? I though everyone

[GitHub] flink pull request: Make Expression API available to Java, Rename ...

2015-03-19 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/503 Make Expression API available to Java, Rename it to Table API This also adds tests and more Javadoc documentation for the Table API. You can merge this pull request into a Git repository by