[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-185132226 Manually merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-185126063 @uce Yes, they could also be moved to separate pages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1645#discussion_r53139307 --- Diff: docs/apis/common/index.md --- @@ -0,0 +1,1356 @@ +--- +title: "Basic Concepts" + +# Top-level navigation +top-nav-group: apis

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1645#discussion_r53139897 --- Diff: docs/apis/common/index.md --- @@ -0,0 +1,1356 @@ +--- +title: "Basic Concepts" + +# Top-level navigation +top-nav-group: apis

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-185116660 Looks great! +1 to merge asap. As follow ups we should consider making windowing and working with state also separate pages. What do you think? --- If your

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-16 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-184876499 +1 I like this to get the redundancy out of the batch and streaming guides. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-16 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1645 Refactor Common Parts of Stream/Batch Documentation The main bit is the refactoring, I also added a basic RocksDB documentation and created a new "Working with Time" section for the streaming