[GitHub] flink pull request #2063: [FLINK-4002] [py] Improve testing infraestructure

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2063


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2063: [FLINK-4002] [py] Improve testing infraestructure

[omaralvarez]

GitHub user omaralvarez opened a pull request:

https://github.com/apache/flink/pull/2063

[FLINK-4002] [py] Improve testing infraestructure

The Verify() test function now does not error out when array elements are 
missing:

```python
env.generate_sequence(1, 5)\
 .map(Id()).map_partition(Verify([1,2,3,4], "Sequence")).output()
```

I have also documented test functions.

While documenting, two questions arise. First, Verify2 function has no use 
as is, performing a `if value in self.expected:` before:

```python
try:
self.expected.remove(value)
except Exception:
raise Exception()
```

Makes this function useless, since it will never raise and exception, if I 
am not mistaken. 

Also, I am not sure why there are two test scripts, `main_test.py` and 
`main_test2.py`. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omaralvarez/flink py_testing

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2063


commit 784a602167f396cdcd1201509d3c122a5a85248f
Author: omaralvarez 
Date:   2016-06-02T09:09:08Z

[FLINK-4002] [py] Improve testing infraestructure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---