[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69039259 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -471,6 +471,32 @@ class Table( } /**

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69039071 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -446,9 +446,9 @@ class Table( } /**

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037753 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -83,66 +82,68 @@ class

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037698 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -83,66 +82,68 @@ class

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69036989 --- Diff: docs/apis/table.md --- @@ -535,6 +535,30 @@ Table result = left.unionAll(right); + + Intersect +

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r69037003 --- Diff: docs/apis/table.md --- @@ -535,6 +535,30 @@ Table result = left.unionAll(right); + + Intersect +

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68474570 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -260,10 +260,14 @@ class CodeGenerator(

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68474420 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/IntersectITCase.scala --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68474131 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/IntersectITCase.java --- @@ -0,0 +1,101 @@ +/* + *

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68473826 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -446,6 +446,31 @@ class Table( } /**

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68473636 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala --- @@ -446,6 +446,31 @@ class Table( } /**

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68473250 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -0,0 +1,153 @@ +/*

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68473118 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -0,0 +1,153 @@ +/*

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68473031 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -0,0 +1,153 @@ +/*

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2159#discussion_r68471662 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala --- @@ -0,0 +1,153 @@ +/*

[GitHub] flink pull request #2159: [FLINK-3942] [tableAPI] Add support for INTERSECT

2016-06-24 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/2159 [FLINK-3942] [tableAPI] Add support for INTERSECT Internally, I translate INTERSECT into a Join on all fields and then a distinct for removing duplicate records. As Calcite SQL Parser