Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70843655
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70828017
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70828051
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70828069
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70827977
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70827999
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70827769
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricGetter.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70827198
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70780347
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70591835
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70591698
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70591379
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/metrics/KafkaMetricGetter.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70591328
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70591165
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70590934
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2236#discussion_r70589875
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
---
@@
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2236
[FLINK-4186] Use Flink metrics to report Kafka metrics
We were using Flink's accumulators in the past to report the Kafka metrics.
With this change, we'll use the new metrics of Flink.
18 matches
Mail list logo
