Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86554520
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86549923
--- Diff:
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.metrics.jade
---
@@ -0,0 +1,47 @@
+//
+ Licensed to the Apache
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86548295
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86530365
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86526490
--- Diff:
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.subtasks.jade
---
@@ -26,6 +26,7 @@
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86526375
--- Diff:
flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.node-list.metrics.jade
---
@@ -0,0 +1,47 @@
+//
+ Licensed to the Apache Software
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86396887
--- Diff: .gitignore ---
@@ -28,3 +30,5 @@ out/
/docs/Gemfile.lock
/docs/.bundle
/docs/.rubydeps
+*.ipr
+*.iws
--- End diff --
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86396834
--- Diff: .gitignore ---
@@ -16,6 +16,8 @@ tmp
*.jar
*.log
.DS_Store
+_site
+docs/api
--- End diff --
Changes here should not
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86397283
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -21,7 +20,9 @@
"dagre-d3": "0.4.17",
"font-awesome": "4.5.0",
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86526289
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if="job")
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85606565
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
---
@@ -383,25 +384,28 @@ private void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85604825
--- Diff: flink-runtime-web/web-dashboard/app/scripts/index.coffee ---
@@ -39,6 +39,8 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])
.run
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r85604628
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/socket/SocketWindowWordCount.java
---
@@ -30,7 +30,7 @@
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2724
[FLINK-4221] Show metrics in WebFrontend + general improvements
Other included changes:
- Removed Properties tab
- Renamed plan to overview
- Added parallelism to task list
15 matches
Mail list logo
