[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2017-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2805 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-07 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r91306180 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java --- @@ -131,35 +132,30 @@ private void sendToTarget(T

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-04 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r90777420 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java --- @@ -215,6 +189,31 @@ public Void

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-04 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r90778003 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -421,22 +423,19 @@ private

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-04 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r90777407 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java --- @@ -215,6 +189,31 @@ public Void

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-04 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r90777958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java --- @@ -131,35 +132,30 @@ private void sendToTarget(T

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-12-04 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r90777962 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java --- @@ -71,21 +68,26 @@ public void

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-11-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r87968119 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -586,7 +588,18 @@ private boolean

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-11-15 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r87967007 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -586,7 +588,18 @@ private boolean

[GitHub] flink pull request #2805: [FLINK-5059] only serialise events once in RecordW...

2016-11-15 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/2805#discussion_r87965585 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -586,7 +588,18 @@ private boolean