[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-13 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/2871 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90639571 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -58,12 +63,14 @@

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90641264 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/SourceFunctionTest.java --- @@ -52,12 +52,4 @@ public void fromCollectionTest()

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90641362 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java --- @@ -73,27 +76,31 @@

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90643076 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -104,21 +114,63

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90639653 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @@ -62,6 +73,9 @@ /**

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-12-02 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2871#discussion_r90641176 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/StatefulSequenceSource.java --- @@ -18,25 +18,44 @@

[GitHub] flink pull request #2871: [FLINK-5163] Ports the production functions to the...

2016-11-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2871 [FLINK-5163] Ports the production functions to the new state abstraction. This includes the following functions: 1) `StatefulSequenceSource` 2) `MessageAcknowledgingSourceBase` 3)