Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/3026
---
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97317694
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/groupings.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97299113
--- Diff: docs/dev/table_api.md ---
@@ -790,6 +790,40 @@ val result = in.groupBy('a).select('a, 'b.sum as 'd);
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97306898
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -688,4 +726,37 @@ object array {
}
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97306369
--- Diff: docs/dev/table_api.md ---
@@ -2714,6 +2748,42 @@ ARRAY.element()
+
+
+{% highlight scala
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97314983
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionUtils.scala
---
@@ -151,4 +155,35 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97298808
--- Diff: docs/dev/table_api.md ---
@@ -790,6 +790,40 @@ val result = in.groupBy('a).select('a, 'b.sum as 'd);
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97320762
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -94,7 +94,24 @@ case class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97314389
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
@@ -176,6 +179,12 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97317531
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/groupings.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97314552
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
@@ -375,15 +393,26 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97312088
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/Expression.scala
---
@@ -86,3 +85,44 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97311360
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -928,5 +1032,151 @@ class GroupWindowedTable(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97313779
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
@@ -375,15 +393,26 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97324083
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -408,10 +408,20 @@ public static void
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97307329
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -15,14 +15,17 @@
* See the License for the specific
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97323770
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/GroupingSetsTest.scala
---
@@ -0,0 +1,150 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97312771
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/Expression.scala
---
@@ -86,3 +85,44 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97304886
--- Diff: docs/dev/table_api.md ---
@@ -2714,6 +2748,42 @@ ARRAY.element()
+
--- End diff --
Can you add a
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97312920
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/Expression.scala
---
@@ -86,3 +85,44 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97306096
--- Diff: docs/dev/table_api.md ---
@@ -2714,6 +2748,42 @@ ARRAY.element()
+
+
+{% highlight scala
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97322915
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -616,6 +706,118 @@ case class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97313160
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
@@ -289,12 +298,21 @@ object
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97298700
--- Diff: docs/dev/table_api.md ---
@@ -790,6 +790,40 @@ val result = in.groupBy('a).select('a, 'b.sum as 'd);
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97305200
--- Diff: docs/dev/table_api.md ---
@@ -2714,6 +2748,42 @@ ARRAY.element()
+
+
+{% highlight scala
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97322831
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -264,6 +281,79 @@ case class Aggregate(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97310709
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -928,5 +1032,151 @@ class GroupWindowedTable(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97311604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -928,5 +1032,151 @@ class GroupWindowedTable(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97312299
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/Expression.scala
---
@@ -86,3 +85,44 @@ abstract class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3026#discussion_r97308739
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/package.scala
---
@@ -66,7 +66,7 @@ import
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/3026
[FLINK-2980] [table] Support for GROUPING SETS clause in Table API.
Support for operators GROUPING SETS / ROLLUP / CUBE in Table AP was added
in this PR.
Also added some tests for check
31 matches
Mail list logo
