[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3393#discussion_r102723574
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is
installed to
~~~
{% endif %}
+### Alternatively
--- End diff --
Yes. And perhaps use the `` formatting
as with `dataset_transformation.md` and elsewhere. With tabs it is easy to see
the different choices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3393#discussion_r102675770
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is
installed to
~~~
{% endif %}
+### Alternatively
--- End diff --
Should we also put to OSX installation into the if/else?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3393#discussion_r102515804
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is
installed to
~~~
{% endif %}
+### Alternatively
--- End diff --
What if we renamed "Alternatively" to "Install on MacOS".
And perhaps pull the prior "Download" into the if/else and rename to
"Download and Unpack" and "Download and Compile"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3393: [FLINK-3903][docs] adding alternative installation...
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3393
[FLINK-3903][docs] adding alternative installation documentation for â¦
â¦OSX users
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heytitle/flink
FLINK-3903-homebrew-installation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3393
commit 0539e3f72e19ba5523410b4b03bd446969c8fbb7
Author: heytitle
Date: 2017-02-22T16:04:42Z
[FLINK-3903][docs] adding alternative installation documentation for OSX
users
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
