[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104298836 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala --- @@ -0,0 +1,87 @@ +/*

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104298833 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104298822 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -0,0 +1,103 @@ +/* +

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104290767 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104290608 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetAggFunction.scala --- @@ -0,0 +1,103 @@ +/*

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-04 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104292001 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/DataSetPreAggFunction.scala --- @@ -0,0 +1,87 @@

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104282353 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104282131 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3472 [FLINK-5963] [table] Remove prepare mapper of DataSetAggregate. We remove the preparation mapper to - save one operator - be able to apply `AggregateFunction.accumulate()` in a