Github user dawidwys closed the pull request at:
https://github.com/apache/flink/pull/3477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106163326
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106163471
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106142891
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106162103
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106150181
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106150129
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -74,11 +80,35 @@ public long getStartTimestamp() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106142265
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106141824
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108553
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106107521
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106106765
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108080
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108841
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106107383
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106108473
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -74,88 +76,233 @@
*/
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r106109112
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -74,11 +80,35 @@ public long getStartTimestamp() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105857530
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java
---
@@ -18,9 +18,13 @@
package
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854241
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj) {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105851817
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854452
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105857595
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105851882
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -41,8 +43,11 @@
// Timestamp of the first
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854576
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105851855
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -52,14 +57,35 @@ public ComputationState(
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105856821
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854765
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105857618
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105855825
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
@@ -55,6 +65,7 @@ public boolean equals(Object obj) {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105857677
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854967
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105855625
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -217,23 +217,22 @@ public void prune(long
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854471
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105853157
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105854116
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj) {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105855001
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105856015
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105855949
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/InvalidPatternException.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700201
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700521
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105702715
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105697591
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -52,14 +57,35 @@ public ComputationState(
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699655
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704530
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105697452
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -41,8 +43,11 @@
// Timestamp of the first
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698150
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final NonDuplicatingTypeSerializer
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699988
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700500
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704399
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698031
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -71,19 +70,16 @@
private final NonDuplicatingTypeSerializer
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704335
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105699441
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105704267
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java
---
@@ -272,37 +372,42 @@ public void testBranchingPattern() {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105702323
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/compiler/NFACompilerTest.java
---
@@ -18,9 +18,13 @@
package
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105698626
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -209,33 +204,66 @@ public boolean equals(Object obj) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105701064
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -217,23 +217,22 @@ public void prune(long
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105700356
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -247,27 +275,148 @@ public int compare(final StateTransition o1,
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3477#discussion_r105701669
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
---
@@ -55,6 +65,7 @@ public boolean equals(Object obj) {
58 matches
Mail list logo
