Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r108438856
--- Diff:
flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayInputStreamWithPosTest.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r108437565
--- Diff:
flink-core/src/main/java/org/apache/flink/core/memory/ByteArrayInputStreamWithPos.java
---
@@ -118,7 +118,8 @@ public int getPosition() {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r108437640
--- Diff:
flink-core/src/main/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPos.java
---
@@ -110,7 +110,7 @@ public int getPosition() {
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r107696959
--- Diff:
flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r107697744
--- Diff:
flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3595#discussion_r107423467
--- Diff:
flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to
GitHub user wenlong88 opened a pull request:
https://github.com/apache/flink/pull/3595
[FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPosition
Currently the precondition check in setPosition will fail when the buffer
is full:
{{Preconditions.checkArgument(position <
