Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3698#discussion_r113663695
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAITCase.java 
---
    @@ -1609,7 +1549,7 @@ public boolean filter(Event value) throws Exception {
     
                compareMaps(resultingPatterns, Lists.<List<Event>>newArrayList(
                                Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent2, 
ConsecutiveData.end),
    -                           Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.middleEvent2, ConsecutiveData.middleEvent3, ConsecutiveData.end)
    +                           Lists.newArrayList(ConsecutiveData.startEvent, 
ConsecutiveData.middleEvent1, ConsecutiveData.middleEvent3, ConsecutiveData.end)
    --- End diff --
    
    Here the expected result should only be the first pattern, because we are 
in `consecutive` mode.
    The problem  is the 
    
    ```
    if (quantifier.hasProperty(Quantifier.QuantifierProperty.CONSECUTIVE) &&
        !quantifier.hasProperty(Quantifier.QuantifierProperty.EAGER)) {
                        //inner branching and no invalid elements in between
                        return (IterativeCondition<T>) pattern.getCondition();
    ```
    in the `getInnerIgnoreCondition()` of the `NFACompiler`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to