[GitHub] flink pull request #3710: [FLINK-6143] [clients] Fix unprotected access to t...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3710 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3710: [FLINK-6143] [clients] Fix unprotected access to t...
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/3710#discussion_r111666520 --- Diff: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java --- @@ -59,7 +59,7 @@ private final Object lock = new Object(); /** The mini cluster on which to execute the local programs */ - private LocalFlinkMiniCluster flink; + private volatile LocalFlinkMiniCluster flink; --- End diff -- @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3710: [FLINK-6143] [clients] Fix unprotected access to t...
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/3710#discussion_r111666373 --- Diff: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java --- @@ -59,7 +59,7 @@ private final Object lock = new Object(); /** The mini cluster on which to execute the local programs */ - private LocalFlinkMiniCluster flink; + private volatile LocalFlinkMiniCluster flink; --- End diff -- Thanks for telling me so useful message. Appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3710: [FLINK-6143] [clients] Fix unprotected access to t...
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3710#discussion_r111663699 --- Diff: flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java --- @@ -59,7 +59,7 @@ private final Object lock = new Object(); /** The mini cluster on which to execute the local programs */ - private LocalFlinkMiniCluster flink; + private volatile LocalFlinkMiniCluster flink; --- End diff -- If we guard all accesses with locks this doesn't have to be volatile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3710: [FLINK-6143] [clients] Fix unprotected access to t...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3710
[FLINK-6143] [clients] Fix unprotected access to this.flink in LocalEâ¦
â¦xecutor#endSession.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink_6143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3710
commit 83904c4e736d17cb32ffcbf1d2f90b5521837284
Author: zhangminglei
Date: 2017-04-11T15:29:50Z
[FLINK-6143] [clients] Fix unprotected access to this.flink in
LocalExecutor#endSession.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
