[GitHub] flink pull request #3825: [FLINK-6445] [cep] Fix NPE in no-condition pattern...

[tedyu]

Github user tedyu commented on a diff in the pull request:

https://github.com/apache/flink/pull/3825#discussion_r114923660
  
--- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/AndCondition.java
 ---
@@ -32,8 +34,8 @@
private final IterativeCondition right;
 
public AndCondition(final IterativeCondition left, final 
IterativeCondition right) {
-   this.left = left;
-   this.right = right;
+   this.left = Preconditions.checkNotNull(left, "The condition 
cannot be null.");
--- End diff --

Better indicate whether left or right is null in the message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3825: [FLINK-6445] [cep] Fix NPE in no-condition pattern...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/3825


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3825: [FLINK-6445] [cep] Fix NPE in no-condition pattern...

[kl0u]

GitHub user kl0u opened a pull request:

https://github.com/apache/flink/pull/3825

[FLINK-6445] [cep] Fix NPE in no-condition patterns.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kl0u/flink cep-null-filter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/3825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3825


commit f94db9bf53b242b5473dde46fc9218a61fa2ce3f
Author: kl0u 
Date:   2017-05-04T13:33:40Z

[FLINK-6445] [cep] Fix NPE in no-condition patterns.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---