[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3943 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3943#discussion_r117928792 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/validation/GroupWindowAggregationsTest.scala --- @@

[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3943#discussion_r117929380 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala --- @@ -120,7 +125,8 @@ object TableTestUtil { }

[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-05-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/3943#discussion_r117929561 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/stringexpr/UnionStringExpressionTest.scala --- @@ -0,0

[GitHub] flink pull request #3943: [FLINK-6617][table] Improve JAVA and SCALA logical...

2017-05-19 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3943 [FLINK-6617][table] Improve JAVA and SCALA logical plans consistent test In this PR. I had make some changes as follows: 1. Add all the tableAPI AVA and SCALA logical plans consistent