[GitHub] flink pull request #4269: FLINK-6557 Fixing tests for RocksDB state backend ...

2018-06-24 Thread vschafer
Github user vschafer closed the pull request at:

https://github.com/apache/flink/pull/4269


---


[GitHub] flink pull request #4269: FLINK-6557 Fixing tests for RocksDB state backend ...

2017-07-06 Thread vschafer
GitHub user vschafer opened a pull request:

https://github.com/apache/flink/pull/4269

FLINK-6557 Fixing tests for RocksDB state backend on Windows

This is an alternate fix for issue FLINK-6557 to 
https://github.com/apache/flink/pull/3899 which seems to have failed in CI 
testing. The proposed fix uses the same technique used to solve this issue in 
other parts of the Flink codebase, making it consistent and easy to refactor in 
the future.

Description from the commit message:
"Fixing tests for RocksDB state backend on Windows. The original path to 
RocksDB contains "/" character at the beginning of the String, which is not 
accepted by the RocksDB implementation. The fix uses logic consistent with 
existing handling of this issue in other parts of the codebase."

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vschafer/flink master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4269


commit 65463ca0b8fdcfa249d9c054c254d98559f54b05
Author: Vladimir Schafer 
Date:   2017-07-06T11:36:21Z

FLINK-6557 Fixing tests for RocksDB state backend on Windows. The original 
path to RocksDB contains "/" character at the beginning of the String, which is 
not accepted by the RocksDB implementation. The fix uses logic consistent with 
existing handling of this issue in other parts of the codebase.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---