Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r130032185
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -478,12 +485,15 @@ public static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129881025
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -478,12 +485,15 @@ public static void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129879671
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
---
@@ -210,6 +207,7 @@ public void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129878926
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -722,12 +697,30 @@ public ApplicationReport
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129878461
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -163,23 +161,17 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129877902
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -549,7 +559,12 @@ protected void runWithArgs(String[] args,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129876779
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -478,12 +485,15 @@ public static void
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129875747
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java ---
@@ -214,22 +218,21 @@ public void addGeneralOptions(Options
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129875590
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java ---
@@ -214,22 +218,21 @@ public void addGeneralOptions(Options
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129875395
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -77,10 +77,10 @@ public StandaloneClusterClient
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129875326
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -58,7 +58,7 @@ public void addGeneralOptions(Options
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129870736
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -62,25 +62,27 @@
* Retrieves a client for a
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129769520
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -77,10 +77,10 @@ public StandaloneClusterClient
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129771505
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -478,12 +485,15 @@ public static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129769550
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -58,7 +58,7 @@ public void addGeneralOptions(Options baseOptions)
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129770778
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java ---
@@ -214,22 +218,21 @@ public void addGeneralOptions(Options
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129774438
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
---
@@ -210,6 +207,7 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129774051
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -163,23 +161,17 @@ public
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129768986
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -62,25 +62,27 @@
* Retrieves a client for a
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129770769
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnCLI.java ---
@@ -214,22 +218,21 @@ public void addGeneralOptions(Options
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129772021
--- Diff:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -549,7 +559,12 @@ protected void runWithArgs(String[] args, String
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4280#discussion_r129777841
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -722,12 +697,30 @@ public ApplicationReport
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4280
[FLINK-7125] [yarn] Remove Configuration loading from
AbstractYarnClusterDescriptor
Instead the AbstractYarnClusterDescriptor is passed in a Configuration
instance which
is sent to the
24 matches
Mail list logo
