[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4305#discussion_r127113118 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -843,11 +843,14 @@ private float convertToFloat(Object o,

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4305#discussion_r127109325 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -843,11 +843,14 @@ private float convertToFloat(Object o,

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/4305#discussion_r127107209 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -843,11 +843,14 @@ private float convertToFloat(Object o,

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4305#discussion_r126946827 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -843,11 +843,14 @@ private float convertToFloat(Object o,

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4305#discussion_r126921674 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -843,7 +843,7 @@ private float convertToFloat(Object o, float

[GitHub] flink pull request #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and D...

2017-07-12 Thread KurtYoung
GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/4305 [FLINK-7161] fix misusage of Float.MIN_VALUE and Double.MIN_VALUE I already checked all places using Float.MIN_VALUE and Double.MIN_VALUE and fixed all misusage. You can merge this pull request