Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4915
---
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148441559
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148227364
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r148226920
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7 +61,
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147942486
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147941508
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -2
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754468
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java
---
@@ -61,7 +61,
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147754127
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147689963
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11 +478,6
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147675169
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -2
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147674418
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -2
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147667457
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147656743
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java
---
@@ -226,13
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147652950
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -563,7 +
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147652455
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147442314
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -563,7 +553,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147436687
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11 +478,6
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4915
[FLINK-7838] Bunch of hotfixes and fix missing synchronization in
FlinkKafkaProducer011
## What is the purpose of the change
Most important is the commit adding missing synchronization, t
18 matches
Mail list logo