Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4933
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148498481
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING || current
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148399427
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING ||
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148399116
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
---
@@ -48,6 +48,8 @@
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148306365
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -844,7 +844,7 @@ else if (current == CANCELING || current
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4933#discussion_r148305773
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
---
@@ -48,6 +48,8 @@
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4933
[FLINK-7960] [tests] Fix race conditions in
ExecutionGraphRestartTest#completeCancellingForAllVertices
## What is the purpose of the change
One race condition is between
