Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5062
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155224199
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -224,6 +225,7 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155224312
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -234,9 +236,14 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155225199
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155212885
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAAbstractQueryableStateTestBase.java
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155212865
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAAbstractQueryableStateTestBase.java
---
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155212313
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
@@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r155201806
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@ -251,34
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154955042
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154950988
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -191,9 +196,12 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154952648
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -66,14
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154950558
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154890905
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -486,27 +542,25 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154890227
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -312,32 +345,41 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154888733
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -133,7 +134,7 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154886964
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154885936
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154885293
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@ -251,34
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154885503
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -133,7 +134,7 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154884801
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@ -251,34
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153799197
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153801913
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -422,20 +467,31
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153804310
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153801762
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -422,20 +467,31
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153793789
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/NonHAAbstractQueryableStateTestBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153794621
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153788979
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -95,15 +97,20 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153798768
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153804523
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153794265
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyImpl.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153786058
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -300,7 +333,7 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153799484
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153798113
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153793887
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/HAAbstractQueryableStateTestBase.java
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153797256
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153790466
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -86,77
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153802908
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -486,27 +542,25
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153790032
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -60,23
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153796142
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153789622
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -218,7 +225,18 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153786954
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -312,32 +345,41
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153785916
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -166,28 +167,57
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153797851
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153798592
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -133,7 +134,7 @@
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153790485
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -86,77
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153794159
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/server/KvStateServerImpl.java
---
@@ -101,6
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/5062
[FLINK-7880][QS] Wait for proper resource cleanup after each ITCase.
R @aljoscha
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink
47 matches
Mail list logo
