[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153566048 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -188,13 +188,6 @@ object

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153566038 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/MapTypeTest.scala --- @@ -139,13 +139,6 @@ class MapTypeTest

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153449102 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/MapTypeTest.scala --- @@ -139,13 +139,6 @@ class MapTypeTest

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-28 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5070#discussion_r153448795 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala --- @@ -188,13 +188,6 @@ object

[GitHub] flink pull request #5070: [FLINK-8151][table]Remove Map type equality compar...

2017-11-25 Thread walterddr
GitHub user walterddr opened a pull request: https://github.com/apache/flink/pull/5070 [FLINK-8151][table]Remove Map type equality comparison. Remove map type equality support as unlike java array, there's no element-wise equality check on Map type. Also small clean up on