Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173148163
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/MetricGroup.java
---
@@ -87,9 +89,27 @@
* @param gauge gauge
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173149289
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporterV2.java
---
@@ -0,0 +1,89 @@
+/*
+ *
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173150593
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/metrics/ScalaGauge.scala
---
@@ -23,6 +23,7 @@ import org.apache.flink.metrics.Gauge
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173146108
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/NumberGauge.java
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173146558
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/StringGauge.java
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173146575
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/NumberGauge.java
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5501#discussion_r173147513
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -460,4 +474,77 @@ protected
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5501
[FLINK-6053][metrics] Add new Number-/StringGauge metric types
## What is the purpose of the change
This PR deprecates the `Gauge` metric type and introduces 2 new metric
types:
