Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171354820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171292456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171280725
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5564
---
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170569676
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170569299
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170562304
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaValidator.java
---
@@ -0,0 +1,123 @@
+/*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170561781
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170304145
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170291034
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala
---
@@ -18,48 +18,67 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170224845
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java
---
@@ -83,10
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230041
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170257053
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170257084
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170273135
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala
---
@@ -41,10 +41,10 @@ trait
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170290993
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/RowtimeTest.scala
---
@@ -18,48 +18,67 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256851
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170229569
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -128,6 +165,13 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230912
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170271213
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/Schema.scala
---
@@ -32,11 +32,36 @@ import
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170296912
--- Diff:
flink-formats/flink-json/src/main/java/org/apache/flink/table/descriptors/JsonValidator.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256878
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170230028
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -155,6 +199,28 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170273904
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/CsvTest.scala
---
@@ -47,53 +79,18 @@ class CsvTest extends
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170274382
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170298004
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170232160
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -246,13 +394,93 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256073
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170272030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +92,188 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170297941
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170229924
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -89,37 +105,58 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256006
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170256141
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/RowtimeValidator.scala
---
@@ -77,58 +73,113 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175473
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170188551
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170181909
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala
---
@@ -43,7 +42,7 @@ object
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170175378
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/descriptors/DescriptorTestBase.scala
---
@@ -18,37 +18,85 @@
package
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170194561
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.scala
---
@@ -27,13 +27,27 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170180103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/DescriptorProperties.scala
---
@@ -178,46 +244,128 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170191830
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r170185039
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaValidator.java
---
@@ -0,0 +1,123 @@
+/*
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5564
[FLINK-8538] [table] Add a Kafka table source factory with JSON format
## What is the purpose of the change
This PR is a continuation of #5505. Since this is the first connector with
43 matches
Mail list logo
