Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5581
---
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r171210203
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -182,7 +182,7 @@ private static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r171181261
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -182,7 +182,7 @@ private static void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170993496
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -222,59 +219,24 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170990471
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -138,11 +145,68 @@ static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170921245
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -332,56 +290,41 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170921214
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -222,59 +219,24 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170921349
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -138,11 +145,68 @@ static void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5581#discussion_r170917769
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -138,11 +145,68 @@ static void
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5581
[FLINK-8755][FLINK-8786][network] fix two bugs in spilled and spillable
subpartition views
## What is the purpose of the change
1) `SpilledSubpartitionView#getNextBuffer()` relies on the
10 matches
Mail list logo