[GitHub] flink pull request #5623: [FLINK-8807] Fix ZookeeperCompleted checkpoint sto...

[aljoscha]

Github user aljoscha closed the pull request at:

https://github.com/apache/flink/pull/5623


---

[GitHub] flink pull request #5623: [FLINK-8807] Fix ZookeeperCompleted checkpoint sto...

[aljoscha]

GitHub user aljoscha opened a pull request:

https://github.com/apache/flink/pull/5623

[FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in 
infinite loop

Before, CompletedCheckpoint did not have proper equals()/hashCode(),
which meant that the fixpoint condition in
ZooKeeperCompletedCheckpointStore would never hold if at least on
checkpoint became unreadable.

This adds proper equals()/hashCode() to CompletedCheckpoint and extends
the test to properly create new CompletedCheckpoints. Before, we were
reusing the same CompletedCheckpoint instances, meaning that
Objects.equals()/hashCode() would make the test succeed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aljoscha/flink jira-8807-zookeeper-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5623


commit 777ddb57ee72d200d1312dc8e6dfdb52af6b9950
Author: Aljoscha Krettek 
Date:   2018-03-02T16:46:56Z

[FLINK-8807] Fix ZookeeperCompleted checkpoint store can get stuck in 
infinite loop

Before, CompletedCheckpoint did not have proper equals()/hashCode(),
which meant that the fixpoint condition in
ZooKeeperCompletedCheckpointStore would never hold if at least on
checkpoint became unreadable.

This adds proper equals()/hashCode() to CompletedCheckpoint and extends
the test to properly create new CompletedCheckpoints. Before, we were
reusing the same CompletedCheckpoint instances, meaning that
Objects.equals()/hashCode() would make the test succeed.




---