[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173888555 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173881141 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173879267 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173863375 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173860901 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173857218 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -148,6 +148,13 @@ object SchemaValidator

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173791129 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -148,6 +148,13 @@ object SchemaValidator

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173786510 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -148,6 +148,13 @@ object

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-12 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173784883 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -148,6 +148,13 @@ object SchemaValidator

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-09 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5662#discussion_r173465435 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala --- @@ -198,14 +205,20 @@ object

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5662 ---

[GitHub] flink pull request #5662: [FLINK-8854] [table] Fix schema mapping with time ...

2018-03-08 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5662 [FLINK-8854] [table] Fix schema mapping with time attributes ## What is the purpose of the change This PR fixes the invalid field mapping and improves the mapping of time attributes in