Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5737
---
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176676947
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176515090
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176517944
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/client/SerializedJobExecutionResultTest.java
---
@@ -21,83 +21,98 @@
import
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176515453
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176515734
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176515638
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176518316
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
---
@@ -45,84 +47,87 @@
* b) are not
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176516910
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176517725
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobAccumulatorsInfo.java
---
@@ -50,13 +51,13 @@
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176517187
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/SerializedJobExecutionResult.java
---
@@ -48,8 +49,9 @@
* @param
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176514312
--- Diff:
flink-core/src/main/java/org/apache/flink/util/OptionalFailure.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176454726
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
---
@@ -45,84 +47,87 @@
* b) are not compatible
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176207009
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java
---
@@ -67,22 +72,29 @@ public String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176208188
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java
---
@@ -45,84 +47,87 @@
* b) are not
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176207225
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/accumulators/StringifiedAccumulatorResult.java
---
@@ -67,22 +72,29 @@ public String
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5737#discussion_r176212439
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -763,48 +764,32 @@ public Executor
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5737
[FLINK-8721][flip6] Handle archiving failures for accumulators
During archivization, wrap errors thrown by users' Accumulators into a
FailedAccumulator and do not fail the job because of that.
18 matches
Mail list logo
