[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5867 ---

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184099775 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184098778 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184098177 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184096235 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183748841 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183746951 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183743259 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -95,6 +95,8 @@ DEFAULT_ENV_LOG_MAX=5 # Maximum number of old log

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183721315 --- Diff: flink-libraries/flink-sql-client/bin/sql-client.sh --- @@ -44,20 +44,32 @@ bin=`dirname "$target"` . "$bin"/config.sh if [ "$FLINK_I

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183729075 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-19 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r182650740 --- Diff: flink-libraries/flink-sql-client/bin/sql-client.sh --- @@ -44,20 +44,32 @@ bin=`dirname "$target"` . "$bin"/config.sh if [ "$FLINK_

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-18 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5867 [FLINK-8686] [sql-client] Improve basic embedded SQL client ## What is the purpose of the change This PR covers the following minor improvements: - Configure JVM heap size - "Th