florianschmidt1994 opened a new pull request #6453: [FLINK-9874][E2E Tests] Fix set_ssl_conf for macOS URL: https://github.com/apache/flink/pull/6453 ## What is the purpose of the change This fixes the set_ssl_conf utility function under macOS. The previous version was using `hostname -I` regardless of the OS, but the -I option is not available on the BSD version of the hostname command. This is now fixed by checking for all IPv4 addresses from ifconfig if the OS is macOS and formatting the output to be identical to `hostname -I`. Additionally the filtering of the output is removed so that now all ip addresses are appended to the SANSTRING instead of just one. ## Verifying this change - Successfully ran `./run-single-test.sh test-scripts/test_batch_allround.sh` (this uses SSL setup) on macOS 10.13.6 - Successfully ran `./run-single-test.sh test-scripts/test_batch_allround.sh` (this uses SSL setup) on Ubuntu 16.04.4 ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
