[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView

sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-450044090 Merging.. This is an automated message

[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView

sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-449792220 @dianfu thanks for the updated! I like this way of harness testing, it can cover codegen logic! +1

[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView

sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-447734443 @dianfu the FLINK-11074 has been merged, I am very grateful if you can add the harness in current PR.

[GitHub] sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView

sunjincheng121 commented on issue #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView URL: https://github.com/apache/flink/pull/7201#issuecomment-445091806 Hi @twalthr @walterddr @dianfu I totally agree that any changes will be covered by the test case！Thanks