[GitHub] sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible

2019-01-17 Thread GitBox
sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible URL: https://github.com/apache/flink/pull/7286#issuecomment-455105860 Merging...

[GitHub] sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible

2019-01-15 Thread GitBox
sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible URL: https://github.com/apache/flink/pull/7286#issuecomment-454676934 Hi @dianfu Thanks for the quickly update! LGTM. +1 to merged.

[GitHub] sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible

2019-01-09 Thread GitBox
sunjincheng121 commented on issue #7286: [FLINK-8739] [table] Optimize DISTINCT aggregates to use the same distinct accumulator if possible URL: https://github.com/apache/flink/pull/7286#issuecomment-452673093 @dianfu Thanks for the PR. I'll take look at the change after you rebase the