[GitHub] tillrohrmann commented on issue #6334: [FLINK-5232] Add a Thread default uncaught exception handler on the JobManager

2018-08-13 Thread GitBox
tillrohrmann commented on issue #6334: [FLINK-5232] Add a Thread default 
uncaught exception handler on the JobManager
URL: https://github.com/apache/flink/pull/6334#issuecomment-412427923
 
 
   I'll close this PR when merging #6539 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tillrohrmann commented on issue #6334: [FLINK-5232] Add a Thread default uncaught exception handler on the JobManager

2018-08-10 Thread GitBox
tillrohrmann commented on issue #6334: [FLINK-5232] Add a Thread default 
uncaught exception handler on the JobManager
URL: https://github.com/apache/flink/pull/6334#issuecomment-412116926
 
 
   Hi @yanghua, I think your approach goes in the right direction. Extending 
`ActorSystemImpl` allows us to set a custom uncaught exception handler. It is a 
bit tricky since we have to put our own `RobustActorSystem` in the same package 
as `ActorSystemImpl`. But I think this is ok since it only affects a single 
class. I've taken your work and extended it a bit in #6539 (second commit). 
What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services