[GitHub] tzulitai commented on issue #7861: [FLINK-11747] [ Connectors / ElasticSearch] Expose RestHighLevelClient to allow for custom sniffing

2019-02-28 Thread GitBox
tzulitai commented on issue #7861: [FLINK-11747] [ Connectors / ElasticSearch] 
Expose RestHighLevelClient to allow for custom sniffing
URL: https://github.com/apache/flink/pull/7861#issuecomment-468524553
 
 
   @flinkbot disapprove architecture


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] tzulitai commented on issue #7861: [FLINK-11747] [ Connectors / ElasticSearch] Expose RestHighLevelClient to allow for custom sniffing

2019-02-28 Thread GitBox
tzulitai commented on issue #7861: [FLINK-11747] [ Connectors / ElasticSearch] 
Expose RestHighLevelClient to allow for custom sniffing
URL: https://github.com/apache/flink/pull/7861#issuecomment-468524319
 
 
   @flinkbot disapprove architecture
   
   This would not work.
   The client is only created in the `open` method, and is therefore always 
`null` pre-flight on the client side. That's why the connector allows the 
`RestClient` to be configured via a `RestClientFactory`.
   
   @Salatich can you briefly describe how the client is used to allow for 
custom sniffing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services